From b268aea0abc6c605d665a7f1b89bb55cc07ce5be Mon Sep 17 00:00:00 2001 From: Will Miles Date: Sat, 25 Oct 2025 13:43:10 -0400 Subject: [PATCH] set_metadata: Apply code fixes from @coderabbit --- pio-scripts/set_metadata.py | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/pio-scripts/set_metadata.py b/pio-scripts/set_metadata.py index 5a1c1ae1..e0234005 100644 --- a/pio-scripts/set_metadata.py +++ b/pio-scripts/set_metadata.py @@ -79,9 +79,11 @@ def get_github_repo(): PACKAGE_FILE = "package.json" def get_version(): - with open(PACKAGE_FILE, "r") as package: - return json.load(package)["version"] - return None + try: + with open(PACKAGE_FILE, "r") as package: + return json.load(package)["version"] + except (FileNotFoundError, KeyError, json.JSONDecodeError): + return None def has_def(cppdefs, name): @@ -105,7 +107,7 @@ def add_wled_metadata_flags(env, node): if not has_def(cdefs, "WLED_VERSION"): version = get_version() if version: - cdefs.append(("WLED_VERSION", get_version())) + cdefs.append(("WLED_VERSION", version)) # This transforms the node in to a Builder; it cannot be modified again return env.Object(