From e2b8f91417a8203010fc68f900a226e0eeb81965 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Sun, 5 Oct 2025 15:12:07 +0000 Subject: [PATCH] Reference Hardware Compilation section for common environments list Co-authored-by: netmindz <442066+netmindz@users.noreply.github.com> --- .github/copilot-instructions.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/copilot-instructions.md b/.github/copilot-instructions.md index a7e20d2a..bc1f9761 100644 --- a/.github/copilot-instructions.md +++ b/.github/copilot-instructions.md @@ -40,7 +40,7 @@ The build has two main phases: 2. **Build at least one hardware environment**: `pio run -e esp32dev` -- Set timeout to 30+ minutes. NEVER CANCEL. - Choose `esp32dev` as it's a common, representative environment - - Alternative environments if needed: `nodemcuv2` (ESP8266) or `esp8266_2m` + - See "Hardware Compilation" section above for the full list of common environments - The build MUST complete successfully without errors - If the build fails, fix the issue before proceeding - **DO NOT skip this step** - it validates that firmware compiles with your changes @@ -166,7 +166,7 @@ package.json # Node.js dependencies and scripts **To ensure CI success, you MUST locally:** - Run `npm test` and ensure it passes -- Run `pio run -e esp32dev` (or another common environment) and ensure it completes successfully +- Run `pio run -e esp32dev` (or another common environment from "Hardware Compilation" section) and ensure it completes successfully - If either fails locally, it WILL fail in CI **Match this workflow in your local development to ensure CI success. Do not mark work complete until you have validated builds locally.**