set_metadata: Apply code fixes from @coderabbit
This commit is contained in:
@@ -79,9 +79,11 @@ def get_github_repo():
|
|||||||
PACKAGE_FILE = "package.json"
|
PACKAGE_FILE = "package.json"
|
||||||
|
|
||||||
def get_version():
|
def get_version():
|
||||||
with open(PACKAGE_FILE, "r") as package:
|
try:
|
||||||
return json.load(package)["version"]
|
with open(PACKAGE_FILE, "r") as package:
|
||||||
return None
|
return json.load(package)["version"]
|
||||||
|
except (FileNotFoundError, KeyError, json.JSONDecodeError):
|
||||||
|
return None
|
||||||
|
|
||||||
|
|
||||||
def has_def(cppdefs, name):
|
def has_def(cppdefs, name):
|
||||||
@@ -105,7 +107,7 @@ def add_wled_metadata_flags(env, node):
|
|||||||
if not has_def(cdefs, "WLED_VERSION"):
|
if not has_def(cdefs, "WLED_VERSION"):
|
||||||
version = get_version()
|
version = get_version()
|
||||||
if version:
|
if version:
|
||||||
cdefs.append(("WLED_VERSION", get_version()))
|
cdefs.append(("WLED_VERSION", version))
|
||||||
|
|
||||||
# This transforms the node in to a Builder; it cannot be modified again
|
# This transforms the node in to a Builder; it cannot be modified again
|
||||||
return env.Object(
|
return env.Object(
|
||||||
|
|||||||
Reference in New Issue
Block a user