set_metadata: Apply code fixes from @coderabbit
This commit is contained in:
@@ -79,8 +79,10 @@ def get_github_repo():
|
||||
PACKAGE_FILE = "package.json"
|
||||
|
||||
def get_version():
|
||||
try:
|
||||
with open(PACKAGE_FILE, "r") as package:
|
||||
return json.load(package)["version"]
|
||||
except (FileNotFoundError, KeyError, json.JSONDecodeError):
|
||||
return None
|
||||
|
||||
|
||||
@@ -105,7 +107,7 @@ def add_wled_metadata_flags(env, node):
|
||||
if not has_def(cdefs, "WLED_VERSION"):
|
||||
version = get_version()
|
||||
if version:
|
||||
cdefs.append(("WLED_VERSION", get_version()))
|
||||
cdefs.append(("WLED_VERSION", version))
|
||||
|
||||
# This transforms the node in to a Builder; it cannot be modified again
|
||||
return env.Object(
|
||||
|
||||
Reference in New Issue
Block a user